Skip to content

Draft: Validate address more carefully when checking self-reachability

Nick Mathewson requested to merge nickm/tor:bug20165 into master

Previously, we would treat any incoming circuit on a non-local channel as meaning that our ORPort was reachable. With this patch, we make sure that the address that the peer says we have is the same as the one we're trying to advertise right now.

Closes #20165 (closed).

Bugfix on 4f5192b2 in 0.1.0.1-rc, when reachability self-tests were first introduced.

github PR at https://github.com/torproject/tor/pull/2054 for CI

Edited by Nick Mathewson

Merge request reports