Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
Tor
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,067
    • Issues 1,067
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 35
    • Merge Requests 35
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Core
  • Tor
  • Merge Requests
  • !222

Closed
Opened Nov 23, 2020 by David Goulet@dgoulet🐋Owner
  • Report abuse
Report abuse

config: Catch missing Bridge for ClientTransportPlugin

  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 6

First of all, tor doesn't support multiple transport name on a single *TransportPlugin line so get rid of that. The manpage has never documented that feature and it complexifies the line for no reason. A user can just use multiple ClientTransportPlugin line instead.

Second, if no Bridge line is found, error immediately and exit. Don't leave the Bridge line alone there leading to bugs like #25528 (closed)

Third, when making sure we have a Bridge line with a ClientTransportPlugin, we now check at the managed proxy list. In order to pull this off, the transport name had to be added to the managed_proxy_t object so we can match for which transport it is used for. And thus justifying the removal of multiple transport support which adds no benefit except complexity.

Fixes #40106 (closed)

Signed-off-by: David Goulet dgoulet@torproject.org

Assignee
Assign to
Reviewer
Request review from
Tor: 0.4.5.x-stable
Milestone
Tor: 0.4.5.x-stable
Assign milestone
Time tracking
Reference: tpo/core/tor!222
Source branch: ticket40106_045_01