Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 338
    • Issues 338
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Merge requests
  • !239

Socks5: handle truncated client requests correctly

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nick Mathewson requested to merge nickm/tor:bug40190_035 into maint-0.3.5 Dec 14, 2020
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 2

Previously, our code would send back an error if the socks5 request parser said anything but DONE. But there are other non-error cases, like TRUNCATED: we shouldn't send back errors for them.

This patch lowers the responsibility for setting the error message into the parsing code, since the actual type of the error message will depend on what problem was encountered.

Fixes bug 40190; bugfix on 0.3.5.1-alpha.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bug40190_035