Draft: conn: Properly close MetricsPort socket on EOF

Handle the EOF situation for a metrics connection. Furthermore, if we failed to fetch the data from the inbuf properly, mark the socket as closed because the caller, connection_process_inbuf(), assumes that we did so on error.

Fixes #40257 (closed)

Signed-off-by: David Goulet dgoulet@torproject.org

changed milestone to %Tor: 0.4.5.x-stable

lgtm; gonna wait for CI though

Looks like there's a crash in metrics/connection.

metrics/connection: [forking] 
============================================================ T= 1611758476
Tor 0.4.5.4-rc-dev (git-89f327a348659b45) died: Caught signal 11
/builds/dgoulet/tor/build/src/test/test(+0x5cd855)[0x557cd33c6855]
/builds/dgoulet/tor/build/src/test/test(smartlist_contains+0x4)[0x557cd33ea064]
/builds/dgoulet/tor/build/src/test/test(smartlist_contains+0x4)[0x557cd33ea064]
/builds/dgoulet/tor/build/src/test/test(add_connection_to_closeable_list+0x27)[0x557cd3387017]
/builds/dgoulet/tor/build/src/test/test(connection_mark_for_close_internal___real+0x68)[0x557cd3372a98]
/builds/dgoulet/tor/build/src/test/test(metrics_connection_process_inbuf+0x263)[0x557cd32de793]
/builds/dgoulet/tor/build/src/test/test(+0x2e3e06)[0x557cd30dce06]
/builds/dgoulet/tor/build/src/test/test(+0x43e994)[0x557cd3237994]
/builds/dgoulet/tor/build/src/test/test(testcase_run_one+0x2f1)[0x557cd3237ce1]
/builds/dgoulet/tor/build/src/test/test(tinytest_main+0x10c)[0x557cd323830c]
/builds/dgoulet/tor/build/src/test/test(main+0x4df)[0x557cd2e8a35f]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb)[0x7f9964c8f09b]
/builds/dgoulet/tor/build/src/test/test(_start+0x2a)[0x557cd2e8a49a]
[Lost connection!] 
  [connection FAILED]

added Needs Revision label

added 90 commits

• 89f327a3...f420eacf - 88 commits from branch tpo/core:maint-0.4.5
• 27b5339c - conn: Properly close MetricsPort socket on EOF
• 210d581e - fixup! conn: Properly close MetricsPort socket on EOF

Compare with previous version

marked this merge request as draft from dgoulet/tor@210d581e

Ok I have fixed this. See the fixup, it is a bit more complicated than I thought but in the end it makes sense.

I've rebased this on latest 045 so CI can pass again.

removed Needs Revision label

added 1 commit

• 5ec720d3 - fixup! conn: Properly close MetricsPort socket on EOF

Compare with previous version

lgtm; squashing, testing, merging.

closed