relay: Don't look at omit flag when building descriptor

That comes from 685c4866 which added that check correctly except for when we build a descriptor.

We already omit the IPv6 address, if we need to, when we encode the descriptor but we need to keep the actual discovered address in the descriptor so we can notice future IP changes and be able to assess that we are not publishable as long as we don't specifically set the omit flag.

This lead to also having tor noticing that our IP changed from (no IPv6 in the descriptor) to a discovered one which would trigger every minute.

Fixes #40279 (closed), #40288 (closed)

Signed-off-by: David Goulet dgoulet@torproject.org

changed milestone to %Tor: 0.4.5.x-stable

changed target branch from master to maint-0.4.5

mentioned in issue #40279 (closed)

added 1 commit

• 5138a9c3 - relay: Don't look at omit flag when building descriptor

Compare with previous version

lgtm; please merge when you're ready.

removed review request for @nickm

requested review from @nickm

requested review from @dgoulet and removed review request for @nickm

merged