Skip to content

WIP: Ticket40042: Replace real_addr with canonical_orport

Nick Mathewson requested to merge nickm/tor:ticket40042 into master

Review notes: Since this commit removed the real_addr field, it's pretty easy to be sure that all the users of that field have been fixed.

But he part of this ticket I'm most concerned about is whether there were any users of "addr" that should have changed to "canonical_orport". I didn't find any cases like that, but maybe I missed some. If you have any thoughts on how I might be able to make sure I didn't miss any, please let me know!

Github CI at is https://github.com/torproject/tor/pull/2010 . Let's be careful and watch out for chutney failures.

This will close #40042 (closed) and #33898 (closed).

Merge request reports

Loading