Skip to content

Fixes for Coverity warnings in ticket #40792

Ghost User requested to merge (removed):ticket40792_mr into main

This addresses a few different issues that all came up in the same Coverity report.

  • In hashx_alloc, Coverity seemed to be erroneously finding an uninitialized memory usage path. Simple patch to quiet the warning.
  • In test_crypto, the failure cases were lazy about freeing memory. Fixed this up.
  • It found some inappropriate casts from time_t to uint32_t that I had basically copied from other call sites where token_bucket_ctr is used. This is a larger change that audits the users of approximate_time() for similar problems and replaces this time source in all token_bucket_ctr users with monotime seconds.

Merge request reports