Bug40876

When Tor excluded a guard due to temporary circuit restrictions, it considered additional primary guards for potential usage by that circuit. This could result in more than the specified number of guards (currently 2) being used, long-term, by the tor client.

This could happen when a Guard was also selected as an Exit node, but it was exacerbated by the Conflux guard restrictions. Both instances have been fixed.

Spec MR: torspec!182 (merged)

I am manually assigning review to you, @nickm, both for arti visibility, and because @dgoulet is not familiar with the C-tor guard code.