GitLab

Fix typos

See merge request !3

Merges !2

Ola Bini authored Jul 09, 2020 and David Goulet committed Oct 27, 2020

Since the original flags are not taken into account when peeking, the peek
recvmsg call will hang forever in certain circumstances, including in all QT
applications running Wayland. This fix simply adds the original flags, so that
the peeking recvmsg call might be nonblocking, if the original call was
nonblocking.

Closes #40001

Signed-off-by: David Goulet <dgoulet@torproject.org>

Originating from: https://bugzilla.redhat.com/show_bug.cgi?id=1601259

Patch by "cHBWyJuH".

Fixes #26794

Signed-off-by: David Goulet <dgoulet@torproject.org>

It gets really noisy with mutt. Not sure why, I expect maybe multi
thread/process makes it that everytime it dies, we get that log statement.
Signed-off-by: David Goulet <dgoulet@torproject.org>

Fixes #25627

Signed-off-by: David Goulet <dgoulet@torproject.org>

Fixes #25586

Signed-off-by: David Goulet <dgoulet@torproject.org>

Fixes #24081

Signed-off-by: David Goulet <dgoulet@torproject.org>

Fixes #23876

Signed-off-by: David Goulet <dgoulet@torproject.org>

Whatever we use IPv4 or IPv6, make torsocks use the configured SocksPort in
the configuration.
Signed-off-by: David Goulet <dgoulet@torproject.org>

The other IP doesn't work anymore and I can't recall what it was ;).
Signed-off-by: David Goulet <dgoulet@torproject.org>

Because of the SafeSocks parameter of Tor, if set, we can't pass a raw IP
address to Tor since it will believe we did a DNS resolution from the
application.

Now, thanks to #22461, Tor safely accepts an IPv4/IPv6 address withing a FQDN
connect request which avoids the SafeSocks warnings.

The #22461 wasn't backported which means that torsocks working with SafeSocks
is only possible in tor >= 0.3.2 stable series.

Fixes #23667

Signed-off-by: David Goulet <dgoulet@torproject.org>

Fixes #22068

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Fixes #17618

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Enough things use this now, that the syscall(2) wrapper should support
it, since glibc doesn't provide a wrapper for it, and the documentation
says to invoke it using syscall(2).

Also, replace spaces for a tab.
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

This option disables all logging by setting TORSOCKS_LOG_LEVEL=1.
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

With this check, we can skip tests that need a running tor when none is
present.

Also update the maatuska hostname for the DNS test.
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

The ht.h generated functions are now flagged with ATTR_UNUSED so the
compiler knows to ignore the warnings if unused.

Remove -fno-strict-overflow as well. Not needed for gcc and clang
doesn't have it.
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Fixes #19376

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

This function is used by utils_is_address_ipv4/6 and has to return 0 on
error or 1 on success.

Fixes #20871

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

On a filesystem not supporting capabilities, an error is thrown out on
stderr which is undesirable and confusing for the user.

This commit throws stderr to /dev/null. The point of this getcap is to
actually see if any capabilities are enabled or none. In the context of
an error, there are none.

Fixes #21088

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Whitelist those four syscalls for the syscall() function.

Patch from "cypherpunks". Closes #21022

Signed-off-by: David Goulet <dgoulet@ev0ke.net>