Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Torsocks
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 38
    • Issues 38
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • Torsocks
  • Issues
  • #15504

Closed
Open
Created Mar 29, 2015 by Yawning Angel@yawning

torsocks's getaddrinfo() is broken.

torsocks's getaddrinfo() implementation does not respect AI_NUMERICHOST.

This is wrong because it will do the resolution anyway, and things that expect to be able to use getaddrinfo() as a super inet_pton() break.

The correct thing to do is to check if the string is an address and return EAI_NONAME if it's not, without doing the tor resolution.

With this, #15497 and #13294 all fixed, aria2c actually works with torsocks again, as long as async dns is disabled. Yay.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking