Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Torsocks
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 38
    • Issues 38
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • Torsocks
  • Issues
  • #16434
Closed
Open
Issue created Jun 24, 2015 by cypherpunks@cypherpunks

fix miscellaneous compiler warnings

The attached patch tweaks things to avoid miscellaneous compiler warnings, from GCC and from the Clang static analyzer:

  • Avoid signed/unsigned comparison with judicious casts, justified by asserts.
  • Use the same type for indices into an array as are used for the size of the array.
  • Make sure variables are initialized even for error branches.
  • Avoid possible null pointer dereference in case of test failure.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking