ISOTime inconsistent naming
control-spec.txt
defines:
-
ISOTime
:2012-01-11 12:15:33
-
ISOTime2
:2012-01-11T12:15:33
-
ISOTime2Frac
:2012-01-11T12:15:33.51
This is confusing because it is ISOTime
which produces two arguments when used as a netdoc keyword parameter, not ISOTime2
. Presumably we should be deprecating ISOTime
for new protocol elements.
proposals/342-decouple-hs-interval.md
refers to IsoTimeNospace
which is not defined anywhere.
proposals/239-consensus-hash-chaining.txt
refers to ISOTIME
.
Most of the rest of the documents write out YYYY-MM-DD SP HH:MM:SS
or YYYY-MM-DDTHH:MM:SS
or whatever, ad hoc.
It is anomalous to have the specification of these elements in the control port protocol spec, when they're used.
I suggest:
- Rename
ISOTime2
toISOTimeNew
- Rename
ISOTime
toISOTimeOld
orISOOldDateTimePair
or something - Reference the correct name in prop 342.
- Change
ISOTIME
in prop 239 toISOTimeNew
(NB this may need to be checked against any implementation that may exist) - Move the definitions to a central file of definitions.
- Replace
YYYY-MM-DD SP HH:MM:SS
andYYYY-MM-DDTHH:MM:SS
with references to the new definition.
Edited by Ian Jackson