Prop#349: Decouple validation from prop#340 packing
Merge request reports
Activity
requested review from @jnewsome
assigned to @mikeperry
added 1 commit
- 377bf42d - Prop#349: Remove obsolte reference to prop#340
- Resolved by Jim Newsome
- Resolved by Jim Newsome
- Resolved by Jim Newsome
requested review from @jnewsome
I think I'm failing at gitlab; I don't see a button so submit another "review" and hit "approve". Maybe it's just as well that @dgoulet have a look too, though.
But yeah, LGTM. As per my comments I think there is room for explaining things a bit better, but I think it's an improvement as-is.
marked this merge request as draft from mikeperry/torspec@7d9ecd9a
- Resolved by Jim Newsome
mentioned in issue #314
added 1 commit
- c137512a - fixup! Prop#349: Decouple validation from prop#340 packing
marked this merge request as draft from mikeperry/torspec@c137512a
- Resolved by Mike Perry
Please register or sign in to reply