Skip to content
Snippets Groups Projects

Prop#349: Decouple validation from prop#340 packing

Merged Mike Perry requested to merge mikeperry/torspec:prop349-clarify into main

If we specify the state machines independently from prop#340, everything ends up cleaner.

This came out of discussions with @jnewsome

Cc: @dgoulet

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jim Newsome
  • Jim Newsome
  • Jim Newsome requested review from @jnewsome

    requested review from @jnewsome

  • I think I'm failing at gitlab; I don't see a button so submit another "review" and hit "approve". Maybe it's just as well that @dgoulet have a look too, though.

    But yeah, LGTM. As per my comments I think there is room for explaining things a bit better, but I think it's an improvement as-is.

  • Mike Perry added 2 commits

    added 2 commits

    • 7d9ecd9a - fixup! Prop#349: Decouple validation from prop#340 packing
    • bd5e045f - fixup! Prop#349: Decouple validation from prop#340 packing

    Compare with previous version

  • Mike Perry marked this merge request as draft from mikeperry/torspec@7d9ecd9a

    marked this merge request as draft from mikeperry/torspec@7d9ecd9a

  • Mike Perry marked this merge request as ready

    marked this merge request as ready

  • Jim Newsome resolved all threads

    resolved all threads

  • Jim Newsome
  • Mike Perry mentioned in issue #314

    mentioned in issue #314

  • Mike Perry added 1 commit

    added 1 commit

    • c137512a - fixup! Prop#349: Decouple validation from prop#340 packing

    Compare with previous version

  • Mike Perry marked this merge request as draft from mikeperry/torspec@c137512a

    marked this merge request as draft from mikeperry/torspec@c137512a

  • Mike Perry marked this merge request as ready

    marked this merge request as ready

  • Jim Newsome
  • Jim Newsome approved this merge request

    approved this merge request

  • Mike Perry resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading