Recover a destination when it stops failing

In legacy/trac#28897 (moved) we count consecutive destination failures. We stop a destination when it fails x (=10?) consecutive times. We stop the scanners if all destinations are stopped.

As teor commented, this can be improved to:

• recover a destination if it starts working again after short time
• error when all destinations fail for long time
• let the operator configure the time or number of failures to consider a destination is failing.

Implementation possibilities:

• A destination failing can be tried again with a low probability
• Wait for some minutes before considering a destination fails (after it has failed)

changed milestone to %sbws: 1.1.x-final in legacy/trac

added actualpoints::1 in Legacy / Trac changes-version-patch in Legacy / Trac component::core tor/sbws in Legacy / Trac milestone::sbws: 1.1.x-final in Legacy / Trac points::1 in Legacy / Trac priority::medium in Legacy / Trac resolution::implemented in Legacy / Trac reviewer::ahf in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac version::sbws 1.0.2 in Legacy / Trac labels

Rewrite description

Trac:
Description: In legacy/trac#28897 (moved) we count consecutive destination failures and stop the scanners if there are not destinations that did not fail x consecutive times.

As teor commented, this can be improved to:

• recover a destination if it starts working again after short time
• error when all destinations fail for long time
• let the operator configure the time or number of failures to consider a destination is failing.

Implementation possibilities:

• A destination failing can be tried again with a low probability
• Wait for some minutes before considering a destination fails (after if has failed)

to

In legacy/trac#28897 (moved) we count consecutive destination failures. We stop a destination when it fails x (=10?) consecutive times. We stop the scanners if all destinations are stopped.

As teor commented, this can be improved to:

• recover a destination if it starts working again after short time
• error when all destinations fail for long time
• let the operator configure the time or number of failures to consider a destination is failing.

Implementation possibilities:

• A destination failing can be tried again with a low probability
• Wait for some minutes before considering a destination fails (after it has failed)

Add keyword to tickets that imply a change of version patch, since it might affect the results, but in a backwards compatible way and doesn't add functionality.

Trac:
Keywords: N/A deleted, changes-version-patch added

https://github.com/torproject/sbws/pull/352

Trac:
Status: new to needs_review

Trac:
Reviewer: N/A to ahf

Looks good. I left a minor comment there, which is more of a style option.

Trac:
Status: needs_review to merge_ready

Thanks, changed that.

Trac:
Actualpoints: N/A to 1

merged

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

closed

changed time estimate to 8h

added 8h of time spent

moved from legacy/trac#29589 (moved)

added Bug label and removed 1 deleted label

added Patch label and removed 1 deleted label