Skip to content
Snippets Groups Projects

Draft: new: scanner: do HTTP POST requests instead of GET

Closed juga requested to merge juga/sbws:m15_issue40130_upload_04 into m15

when the consensus parameter bwscanner is 2.

"Using upload instead of download allows the congestion control algorithms to be under control of the sbws Tor client, instead of the Exit relay. This means that sbws can know when slow start has exited."

This is the 1st optimization for #40130 (closed).

The testing HTTP server has been replaced by the one implemented in onbasca just cause a first try on implementing do_POST was successful only for the 1st sbws request. It only implemnts POST RFC 2388.

Co-authored-by: Georg Koppen gk@torproject.org

Merge request reports

Approval is optional

Closed by jugajuga 2 years ago (Sep 7, 2022 7:30am UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Georg Koppen
  • removed Needs Review label

  • @mikeperry: this looks essentially good to me now. Feel free to have a second look.

  • Georg Koppen
  • juga added 2 commits

    added 2 commits

    • f3b44298 - fixup! chg: stem: Log error on stream XOFF_RECV status
    • d9dc5227 - fixup! chg: stem: Log also when XOFF_SENT is received

    Compare with previous version

  • juga marked this merge request as draft from juga/sbws@f3b44298

    marked this merge request as draft from juga/sbws@f3b44298

  • juga resolved all threads

    resolved all threads

  • removed Needs Revision label

  • added Needs Review label

  • Author Owner

    Before squashing and creating a new mr, i'd wait a bit in case mike propose other fixes.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading