Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Onion Launchpad Onion Launchpad
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Onion Services
  • Onion LaunchpadOnion Launchpad
  • Merge requests
  • !63

Fixes dubious repository ownership error when building GitHub Pages

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Silvio Rhatto requested to merge rhatto/onion-launchpad:hotfix/github-safe-directory into main Jan 31, 2023
  • Overview 4
  • Commits 3
  • Pipelines 1
  • Changes 2

Recently the GitHub Pages workflow started to throw an error related to Git's safe directory config. This is not happening with the GitLab workflows, so it may be unrelated with the python:3.8-bullseye image, and probably has to do with GitHub specifics.

The proposed changeset fixes the error by:

  1. Setting set-safe-directory at the checkout action config.
  2. Introducing a ONION_LAUNCHPAD_SET_SAFE_DIRECTORY environment variable. When it is set to "1", the build script will include the Onion Launchpad working copy path into the user's Git safe directory list.

Actually only 2 fixed the issue, but I leave 1 here for evaluation (and we can remove it if does not makes sense).

Closes #74 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: hotfix/github-safe-directory