Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Anonymous Ticket Portal Anonymous Ticket Portal
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • TPA
  • Anonymous Ticket PortalAnonymous Ticket Portal
  • Merge requests
  • !68

Tests for CreateGitlabAccountRequestView (users)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged MariaV requested to merge more_test into master Jan 27, 2021
  • Overview 0
  • Commits 5
  • Changes 2

Changed a line in CreateGitlabAccountRequestView that caused users that had previously rejected requests to be redirected to success-view before new GitlabAccountRequest was created, which led to the object never being created in database.

Wrote 9 tests testing the functions of the CreateGitlabAccountRequestView, including for:

  • GET, user not logged in
  • POST, user not logged in,
  • GET, user logged in, but no UserIdentifier in database
  • POST, user logged in, but no UserIdentifier in database
  • GET, user logged in, user identifier in database
  • POST, user logged in, user identifier in database, no linked GL requests
  • POST, user logged in, user in database, linked GL request with rejected status
  • POST, user logged in, user in database, linked GL request already existing with PENDING status
  • POST, user attempts to post with bad identifier.

Ran coverage, all logic branches of CreateGitlabAccountRequestView are fully covered at this time.

Edited Jan 27, 2021 by MariaV
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: more_test