Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Anonymous Ticket Portal Anonymous Ticket Portal
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • TPA
  • Anonymous Ticket PortalAnonymous Ticket Portal
  • Merge requests
  • !84

Remove References to old login method (words over string)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged MariaV requested to merge remove_old_login_form_logic into master Feb 17, 2021
  • Overview 0
  • Commits 12
  • Changes 5

Update that removes all references to old login method (individual words) as well as some template and CSS sheet refactoring.

-Modified LoginForm in forms.py only have a single field (login_string).

  • Changed LoginForm custom clean method to only allow for blank or string (eg no if/else validation errors for word/string combination.)
  • Deleted custom LoginForm.is_valid() method (no longer necessary)
  • Commented out display:none for labels on class 'flex-form'
  • Altered the login_form.html template to display proper fieldwrapper with label for login_string.
  • Deleted unused functions on LoginForm (e.g. join_words, etc.)
  • Refactored login_view in views.py to simplify (no results dictionary necessary as login string is now passed as an arg variable to URL instead of in a dict.)
  • Deleted all tests in anonticket/tests.py that refer to old word method.

Ran all tests, all tests passing.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: remove_old_login_form_logic