Draft: Add a CI check for dead links
Closes #14
Merge request reports
Activity
requested review from @lavamind
@lavamind do you know why the ci job is deleting the
public/artifact? i've tried everything i can think of to get gitlab to keep the artifact but it just removes it at the beginning of the job :/https://gitlab.torproject.org/kez/donate-static/-/jobs/186228
Edited by Kez
That project is probably private, so I can't see the log.
Edited by Jérôme Charaoui
199 199 200 200 check_dead_links: 201 201 stage: test 202 image: lycheeverse/lychee 202 image: debian:bullseye-slim 203 203 allow_failure: true 204 dependencies: 205 - build - Comment on lines +204 to +205
I think this might explain the issues with previous artifacts. You don't need to specify
dependencies:because by default it will download all artifacts from the previous pipeline stage. You would want it if there we multiple jobs in thebuildstage producing different artifacts and you wanted to retrieve only those from one (or more) of the jobs as opposed to all.Edited by Jérôme Charaoui changed this line in version 3 of the diff
-
alright, i think i finally tweaked this enough. @anarcat you can see an example ci log from this here. it's running lychee with these args
--no-progress --require-https --exclude '.*?\.onion$' --exclude-all-privateto require links use https (if available), exclude onion urls (lychee doesn't support them, would be a good PR), and excludes all private IP addresses.it looks good to me, and it's actually already found a few broken links on donate-static.
