Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Gitlab Lobby Gitlab Lobby
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • TPA
  • Gitlab LobbyGitlab Lobby
  • Merge requests
  • !15

Add the Ability to Review Lobby Requests -- Refs #24

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open mfonism requested to merge mfonism/gitlab-lobby:24-add-discussion-to-lobby-requests into main Oct 21, 2020
  • Overview 5
  • Commits 9
  • Pipelines 0
  • Changes 13

This MR creates a feature for reviewing lobby requests.

In this flow admins can add comments to lobby requests, and lobby request creators can edit the reason part of their requests accordingly. This exchange can go on until admin understands the reason enough to accept or reject the request.

This MR can build on !8 to notify both admin and request creator of updates made by the other, along with the appropriate url for them to view the thread.

Till then, admin can view the thread of comments from the admin page of the particular lobby request while request creator can view the thread from the endpoint /lobby-requests/<username>/

Closes #24

Edited Oct 22, 2020 by mfonism
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 24-add-discussion-to-lobby-requests