Skip to content

hook into gitlab CI for linting, black, tests, and mypy

anarcat requested to merge ci into main

None of those trigger an error, and some of them (e.g. tests) are even broken (at least locally).

black, in particular, has a bunch of changes, a lot around quotes, but also flake8 errors like "too many blank lines".

flake8 also fails on those, and especially outline issues around a nasty import * that we should generally avoid.

mypy is unhappy about missing stubs for the gitlab module, although that module should have type hints:

https://github.com/python-gitlab/python-gitlab/commit/e4421caafeeb0236df19fe7b9233300727e1933b

.. so I'm not sure what's up with that.

In general, this aims towards the following policies:

  • flake8-clean, with an exception for <120 char lines
  • black-clean
  • unit tests that pass
  • mypy type annotations

We're failing on most of those, but it doesn't mean we shouldn't try to catch future errors those tests could find.

Merge request reports