An error occurred while fetching folder content.
Ting-Yu Lin
authored
Bug 1779846 - Remove an unneeded if-statement in TextServicesDocument::OffsetEntryArray::FindWordRange(). r=masayuki, a=dmeehan This patch fixed a regression caused by Bug 1730084 Part 4 https://phabricator.services.mozilla.com/D125434, which is intended to preserve the behavior of `WordBreaker::FindWord()`. Before Bug 1730084 Part 4, `WordBreaker::FindWord()` returns `[aTextLen + 1, aTextLen + 1]` only when `aOffset > aTextLen`. But `WordBreaker::FindWord()` had an assertion `aOffset <= aTextLen` to guarantee the caller never passes `aOffset > aTextLen`. Thus, we can never go into the `if (res.mBegin > strLen)` in `TextServicesDocument::OffsetEntryArray::FindWordRange()`. However, Bug 1730084 Part 4 wrongly changes the if-statement to `if (range.mEnd == range.mBegin)`, and makes it reachable when `TextServicesDocument::OffsetEntryArray::FindWordRange()` passes `aPos == aLen` into `WordBreaker::FindWord()`. This makes `InitSpellChecker()` failed when `enableSelectionChecking=true`. This patch deletes the originally unreachable error handling if-statement, and adds an assertion to guarantee `strOffset` and `strLen` is valid. Differential Revision: https://phabricator.services.mozilla.com/D156210
Name | Last commit | Last update |
---|---|---|
.. |