Skip to content

test: Only skip Redis test if env vars are unset; fail if server isn't running

stephen requested to merge improve-redis-tests into main

As per the discussion on this ticket - #48 (closed) - the intended behavior for the "is Redis up?" unit test is as follows:

  • Pass if the Redis configuration variables are in place and the Redis server responds to a ping
  • Fail if the Redis configuration variables are in place and the Redis server is not running
  • Skip if the Redis configuration variables are unset

The former behavior of this test would skip if the Redis server was not reachable by ping for any reason, and also did not leverage the configuration variables as intended. This commit fixes both of these issues (and quiets some of mypy's newfound complaints).

Merge request reports