Activity
Patch for review in https://github.com/acatarineu/tor-browser/commits/31575 (two commits).
I investigated a bit where these requests where coming from, and all are from the newtab ActivityStream. The first ones (containing cfr-fxa) are done in ASRouter.jsm, which calls RemoteSettingsClient.jsm and that does a bunch of fetches to sync. The snippets ones are coming from ASRouter.jsm.
There are a bunch of
browser.newtabpage.activity-stream.*prefs that probably we could use to disable these, but I opted for the simple solution of just not loading theAboutNewTab.jsmat all. That means it's not possible anymore to change the newtab page, so I also removed that option from the UI in the patch.Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R addedIf the approach is ok, I think this would also fix #30846 (moved) and #30662 (moved).
Replying to acat:
Patch for review in https://github.com/acatarineu/tor-browser/commits/31575 (two commits).
I investigated a bit where these requests where coming from, and all are from the newtab ActivityStream. The first ones (containing cfr-fxa) are done in ASRouter.jsm, which calls RemoteSettingsClient.jsm and that does a bunch of fetches to sync. The snippets ones are coming from ASRouter.jsm.
There are a bunch of
browser.newtabpage.activity-stream.*prefs that probably we could use to disable these, but I opted for the simple solution of just not loading theAboutNewTab.jsmat all. That means it's not possible anymore to change the newtab page, so I also removed that option from the UI in the patch.Hrm. I am not sure we should strip users from easily adjusting their new tab experience. Would we solve this bug by just flipping the prefs? I guess that would still fix #30846 (moved) as well? What about #30662 (moved)?
Trac:
Status: needs_review to needs_informationIf we's go that route then we should rip the code out not comment it because the latter makes it harder to figure out what part is actually a comment and what part is just code we don't use due to a patch. Let's use commenting just for comments.
So, marking that as
needs revisioneither way.Trac:
Status: needs_information to needs_revision
Keywords: TorBrowserTeam201909R deleted, TorBrowserTeam201909 addedPatch for review in https://github.com/acatarineu/tor-browser/commits/31575+1 (two commits).
Now choosing "Firefox Home" for newtab or home in
about:preferenceswill loadabout:torinstead of Firefox newtab. For newtab the default will beabout:blank.Trac:
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R added
Status: needs_revision to needs_reviewSorry, it still remains to change
Firefox Homestring toTor Browser Homeand localize it. I was not sure whether to do that separately later, but I think it's worth it doing it here, so setting it as revision_needed and will do that change too.Trac:
Keywords: TorBrowserTeam201909R deleted, TorBrowserTeam201909 added
Status: needs_review to needs_revision
Replying to acat:
Sorry, it still remains to change
Firefox Homestring toTor Browser Homeand localize it. I was not sure whether to do that separately later, but I think it's worth it doing it here, so setting it as revision_needed and will do that change too.Note that the English title of the about:tor page is
About Tor. I think we should use that in the preferences UI rather thanTor Browser Homebut of course other people may have different opinions. For me,Tor Browser Homeintroduces a new term without much benefit.Cc: Antonela and Pili in case they have smart things to say ;)
Trac:
Cc: N/A to antonela, piliNote that the English title of the about:tor page is About Tor. I think we should use that in the preferences UI rather than Tor Browser Home but of course other people may have different opinions. For me, Tor Browser Home introduces a new term without much benefit.
Thanks! I think it makes a lot of sense, going that route for now. Patch for review: https://github.com/acatarineu/tor-browser/commits/31575+2.
I also changed this so that the default
about:tordoes not appear asCustom URLinabout:preferences, but asAbout Tor(about:homealso redirects toabout:tor, but that's not the default value forbrowser.startup.homepage).Trac:
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R added
Status: needs_revision to needs_reviewFWIW we fixed #30662 (moved) here as well while we were at it.
