So that it compiles to,

```
if (!(name in result)) {
  result[name] = value;
}
```

instead of,

```
if (!(indexOf.call(result, name) >= 0)) {
  result[name] = value;
}
```

since `result` is an object, not an array.

Trac 31067

Prevents repeat calls to update() on startup

Now that we're setting the active attribute of pair to true before
accepting a client offer, we should be careful to reset it to false if
receiving the offer fails

Save whether the snowflake extension is currently enabled in local
storage so that users do not need to opt-in again every time the browser
is restarted

If there is an active connection through your snowflake proxy, your
snowflake will turn to green

Introduced in ead579a6, `config` is only a global in the webextension.

Arlo Breault authored 5 years ago and Cecylia Bocovich committed 5 years ago

From https://design.firefox.com/icons/icons/desktop/arrowhead-right-12.svg

The test failure was due to pollBorker waiting the full 5 seconds before
polling for the first time.

The lint errors were some trailing whitespace and unecessary fat arrows

This enables breaking the loop from the outside and cleans up the
countdown

This doesn't apply to the webextension but hasn't been factored out in
the build step yet.

Updated the tests to pass with our new snowflake-ips-total stat

Added another metrics item that counts the total availabel snowflakes
(unique by IP address)

- removed trailing ","s
- removed unecessary space before seconds

Also moved the geoip check to occur after we've make sure the proxy IP
hasn't yet been recorded. This is will cut down on unecessary
computation.

Added unit tests for metrics logging. Refactored the logMetrics()
function to allow for easier testing

Change it so that we log the geoip country code of proxies if they poll
within the current metrics epoch. We make sure we log by unique IP
address

Output is now printed out in Tor Directory Protocol Format, as specified
in https://trac.torproject.org/projects/tor/ticket/21315#comment:19.

Added three new metrics:
- proxyIdleCount counts the number of times a proxy polls and receives
no snowflakes
- clientDeniedCount counts the number of times a client requested a
snowflake but none were available
- clientProxyMatchCount counts the number of times a client successfully
received a snowflake

Set the resolution of metrics data collection to be every 24 hours