- Mar 31, 2022
-
-
Nick Mathewson authored
Implement a directory munger to simulate pathological cases in arti-testing (v2) Closes #397 See merge request tpo/core/arti!442
-
Nick Mathewson authored
-
-
Nick Mathewson authored
This feature allows us to detect different failing cases for arti#329 that would otherwise be hard to induce. It works by filtering consensus directory objects and/or microdescriptor objects before introducing them to the directory manager. Closes #397.
-
Nick Mathewson authored
This commit uses the `visibility` and `visible` crates to conditionally make certain structs and their fields public (respectively). This is incredibly dangerous to use for anything besides testing, and I've tried to write the documentation for the feature accordingly.
-
Nick Mathewson authored
Minor retry tuning to improve behavior under failing conditions. See merge request tpo/core/arti!439
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
Replace the next delay field immediately rather than taking it and _then_ setting it. This way, it's never in an incorrect state.
-
Ian Jackson authored
Fix typo See merge request tpo/core/arti!441
-
- Mar 30, 2022
-
-
Dimitris Apostolou authored
-
Nick Mathewson authored
The older default seems (experimentally) to be ridiculously high. Generally, if we can't build a circuit within a handful attempts, that circuit has already timed out... unless there is a fast-failure condition, in which case we're just hammering the network (or our view of it.) Found with `arti-testing` for #329.
-
Nick Mathewson authored
Previously, if we had launch_parallelism > 1, and we were willing to retry building a circuit max_retries times, then we'd launch up to max_retries * launch_parallelism circuits before giving up. Ouch! With this patch, we try to keep the total number of circuits planned and attempted to the actual max_retries limit. Part of #329; found with arti-testing.
-
Nick Mathewson authored
The previous algorithm had two flaws: * It would wait even after the final attempt, when there were no more retries to do. * It would fail to wait between attempts if an error occurred. This refactoring fixes both of these issues, and adds some comments.
-
Nick Mathewson authored
-
Ian Jackson authored
Refactor FallbackDir handling and implement a retry-after-delay mechanism. Closes #406 and #220 See merge request tpo/core/arti!433
-
Ian Jackson authored
Manual merge for just this branch as per tpo/core/arti!433 (comment 2791982) tpo/core/arti!433 (comment 2791993)
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
The FirstHopId type now records an enum that stores whether the hop is a guard or a fallback. This change addresses concerns about remembering to check the type or source of an Id before passing it down to the FallbackState or GuardSet. Making this change required an API change, so that dirmgr can report success/failure status without actually knowing whether it's using a fallback or a guard.
-
Nick Mathewson authored
This is preparation for having separate GuardId and FirstHopId types that distinguish which back-end they index.
-
Nick Mathewson authored
This replaces a hand-coded replacement that was probably a little less efficient.
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
-
-
Nick Mathewson authored
-
Nick Mathewson authored
-
Nick Mathewson authored
The code here uses a new iterator type, since I couldn't find one of these on crates.io. I tried writing the code without it, but it was harder to follow and test.
-
Nick Mathewson authored
We do this by creating a new FallbackSet type that includes status information, and updating the GuardMgr APIs to record success and failure about it when appropriate. We can use this to mark FallbackDirs retriable (or not). With this change, FallbackDir is now stored internally as a Guard in the GuardMgr crate. That's fine: the FallbackDir type really only matters for configuration.
-
Nick Mathewson authored
-
Nick Mathewson authored
-