Skip to content
Snippets Groups Projects

Implement a directory munger to simulate pathological cases in arti-testing (v2)

Merged Implement a directory munger to simulate pathological cases in arti-testing (v2)
nickm/arti:dir-munger-v2 into main
3 unresolved threads
Merged Nick Mathewson requested to merge nickm/arti:dir-munger-v2 into main
3 unresolved threads

This branch supercedes !438 (closed). Instead of adding accesors to tor-netdoc, it uses visible and visibility crates to expose elements as public.

Closes #397 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
crates/tor-netdoc/src/doc/netstatus/rs/md.rs
18 18
19 19 /// A single relay's status, as represented in a microdesc consensus.
20 20 #[derive(Debug, Clone)]
21 #[cfg_attr(
22 feature = "dangerous-expose-struct-fields",
23 visible::StructFields(pub),
24 non_exhaustive
  • Ian Jackson
  • Ian Jackson
    Ian Jackson @Diziet started a thread on commit b1b7ef00
    • crates/tor-netdoc/Cargo.toml
    29 29 # feature voids your "semver warrantee".
    30 30 experimental-api = []
    31 31
    32 # Expose various struct fields as "pub", for testing.
    33 #
    34 # This feature is *super* dangerous for stability and correctness. If you use it
    35 # for anything besides testing, you are probably putting your users in danger.
    36 #
    37 # The struct fields exposed by this feature are not covered by semantic version.
    38 # In fact, using this feature will ives you the opposite of a "semver
    39 # guarantee": you should be mildly surprised when your code _doesn't_ break from
    40 # version to version.
    41 dangerous-expose-struct-fields = ["visible", "visibility"]
  • Ian Jackson
    Ian Jackson @Diziet ·
    Maintainer

    LGTM, two minor comments.

  • Nick Mathewson added 1 commit

    added 1 commit

    Compare with previous version

  • Ian Jackson enabled an automatic merge when the pipeline for 68b614ad succeeds

    enabled an automatic merge when the pipeline for 68b614ad succeeds

  • Nick Mathewson mentioned in issue #426

    mentioned in issue #426

  • Nick Mathewson added 1 commit

    added 1 commit

    • 0725e388 - Re-order attributes so that we can build with Rust 1.53.

    Compare with previous version

  • Nick Mathewson merged

    merged

  • Nick Mathewson mentioned in commit 259622bc

    mentioned in commit 259622bc

  • Nick Mathewson mentioned in merge request !438 (closed)

    mentioned in merge request !438 (closed)

    • Please register or sign in to reply