Code motion and import fixups.

Making these fields pub(crate) is quite reasonable and does away with
the need for accessors.

We put this in cfg.rs, rather than (say) socks.rs, because it has
config relating to both socks.rs and dns.rs.

Code motion and import fixups.

Combine logging config and implementation in arti lib crate

See merge request tpo/core/arti!421

This was clumsy.  Now it is brought together it can be simplified.

This de-duplicates the code that was in those accessors, and is now in
filt_from_opt_str.

Code motion and direct field access.

There are no longer needed, because the code that uses this
configuration now lives in the same module as the configuration
itself.

Code motion and import fixups.

We are going to move LoggingConfig here.  We should follow the
already-public name IMO.

Code motion and import fixups.

Abolish some accessors in drmgr

See merge request tpo/core/arti!423

Ian Jackson authored 3 years ago and Nick Mathewson committed 3 years ago

This makes this information crate-private.  The crate can reasonably
just access it.

Ian Jackson authored 3 years ago and Nick Mathewson committed 3 years ago

Using accessors for crate-only fields is otiose.

Ian Jackson authored 3 years ago and Nick Mathewson committed 3 years ago

Rename this to be named the same as its accessor, and use the rename
feature of builder and serde.  (The shorter name is nicer in the code
IMO.)

Actually throw an anyhow

See merge request tpo/core/arti!422

Prompted by a compiler warning which I weirdly can't seem to reproduce?

ClientCirc: add functions to return the circuit's actual path

Closes #415

See merge request tpo/core/arti!419

Use less space in hashtables for microdescriptors

Closes #386

See merge request tpo/core/arti!415

Closes #415

Alternative API for set_isolation_group().

See merge request tpo/core/arti!418

Each channel now remembers an OwnedChanTarget.

Each circuit now remembers a vector of OwnedChanTarget to represent
the path that it was constructed for.

Part of #415.

This will help with #415

Instead of requiring a `Box<dyn Isolation>`, it now takes either a
`Box<dyn Isolation>`, or an arbitrary `T` that implements
`Isolation`.

This API still allows the user to pass in a `Box<dyn Isolation>` if
that's what they have, but it doesn't require them to Box the
isolation on their own.

Part of #414.

new api for isolation

See merge request tpo/core/arti!377

Absolish builders for CircMgrConfig and DirMgrConfig

See merge request !417

dirmgr: Always send if-modified-since on consensus documents.

Closes #403

See merge request tpo/core/arti!412

See rationale in the comment.