Skip to content
Snippets Groups Projects
Commit 5efdc066 authored by Erik Nordin's avatar Erik Nordin
Browse files

Bug 1837389 - Update failing CI test case r=gregtatum, a=test-only

Fixes a test that works for firefox versions <= the
major version, but fails when bumping the minor version.
This was a logic error in the test that was not exposed
until a minor version bump.

Differential Revision: https://phabricator.services.mozilla.com/D180357
parent 71de9f8d
No related branches found
No related tags found
No related merge requests found
...@@ -13,7 +13,7 @@ const { RemoteSettings } = ChromeUtils.importESModule( ...@@ -13,7 +13,7 @@ const { RemoteSettings } = ChromeUtils.importESModule(
); );
// The full Firefox version string. // The full Firefox version string.
const firefoxFullVersion = AppConstants.MOZ_APP_VERSION; const firefoxFullVersion = AppConstants.MOZ_APP_VERSION_DISPLAY;
// The Firefox major version string (i.e. the first set of digits). // The Firefox major version string (i.e. the first set of digits).
const firefoxMajorVersion = firefoxFullVersion.match(/\d+/); const firefoxMajorVersion = firefoxFullVersion.match(/\d+/);
...@@ -77,8 +77,8 @@ add_task(async function test_filter_current_firefox_version() { ...@@ -77,8 +77,8 @@ add_task(async function test_filter_current_firefox_version() {
filter_expression: ``, filter_expression: ``,
}, },
{ {
name: `env.version <= ${firefoxMajorVersion}`, name: `env.version == ${firefoxFullVersion}`,
filter_expression: `env.version|versionCompare('${firefoxMajorVersion}') <= 0`, filter_expression: `env.version|versionCompare('${firefoxFullVersion}') == 0`,
}, },
{ {
name: `env.version > ${firefoxAlphaZeroVersion}`, name: `env.version > ${firefoxAlphaZeroVersion}`,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment