- Mar 21, 2023
-
-
Andrew Halberstadt authored
Bug 1823694 - [lint.ruff] Disable some warnings we don't actually want to enforce, r=linter-reviewers,andi This disables: PLR0911 too-many-return-statements PLR0912 too-many-branches PLR0913 too-many-arguments PLR0914 too-many-return-statements PLR2004 magic-value-comparison This removes nearly 2000 warnings. Differential Revision: https://phabricator.services.mozilla.com/D173156
-
- Mar 20, 2023
-
-
Andrew Halberstadt authored
This is enabling the PLE and PLC rules across a much larger swatch of the code base. The PLR and PLW are additionally enabled at the warning level (introduces ~2500 new warnings). To avoid extraneous changes in people's patches, rules at the warning level are excluded from --fix. Differential Revision: https://phabricator.services.mozilla.com/D172358
-
Andrew Halberstadt authored
Bug 1811850 - [lint] Replace isort linter with ruff, r=taskgraph-reviewers,linter-reviewers,marco,jcristau This results in some changes from our current `isort` configuration. I'm unclear if it's because ruff isn't at 100% parity with isort, they choose different defaults or if I missed some configuration. Either way, the changes all look reasonable to me (see child commit), so I'm inclined to just accept the new import format it imposes. Differential Revision: https://phabricator.services.mozilla.com/D172348
-
Andrew Halberstadt authored
Ruff is a very fast linter implemented in Rust and it can act as a drop-in replacement for flake8. When running the same set of rules across all files in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff takes 0.9 seconds. Ruff also implements rules from other popular Python linters such as pylint, isort and pyupgrade. There are even plans to implement feature parity with black in the future. Ultimately, it can become our one stop shop for all Python linting and formatting. This stack will swap out all our Python lint tools for ruff (excluding black for now). Differential Revision: https://phabricator.services.mozilla.com/D172313
-
- Mar 17, 2023
-
-
Cristian Tuns authored
Backed out changeset e8fcfc7f8108 (bug 1811850) Backed out changeset f8950d716c9e (bug 1811850) Backed out changeset f650123cc188 (bug 1811850) Backed out changeset d96f90c2c58b (bug 1811850) Backed out changeset c3b0f9666183 (bug 1811850)
-
Andrew Halberstadt authored
This is enabling the PLE and PLC rules across a much larger swatch of the code base. The PLR and PLW are additionally enabled at the warning level (introduces ~2500 new warnings). To avoid extraneous changes in people's patches, rules at the warning level are excluded from --fix. Differential Revision: https://phabricator.services.mozilla.com/D172358
-
Andrew Halberstadt authored
Bug 1811850 - [lint] Replace isort linter with ruff, r=taskgraph-reviewers,linter-reviewers,marco,jcristau This results in some changes from our current `isort` configuration. I'm unclear if it's because ruff isn't at 100% parity with isort, they choose different defaults or if I missed some configuration. Either way, the changes all look reasonable to me (see child commit), so I'm inclined to just accept the new import format it imposes. Differential Revision: https://phabricator.services.mozilla.com/D172348
-
Andrew Halberstadt authored
Ruff is a very fast linter implemented in Rust and it can act as a drop-in replacement for flake8. When running the same set of rules across all files in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff takes 0.9 seconds. Ruff also implements rules from other popular Python linters such as pylint, isort and pyupgrade. There are even plans to implement feature parity with black in the future. Ultimately, it can become our one stop shop for all Python linting and formatting. This stack will swap out all our Python lint tools for ruff (excluding black for now). Differential Revision: https://phabricator.services.mozilla.com/D172313
-