Kathleen Brade authored 5 years ago and Pier Angelo Vendrame committed 1 year ago

When Tor informs the browser that client authentication is needed,
temporarily load about:blank instead of about:neterror and prompt
for the user's key.

If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
control port command to add the key (via Torbutton's control port
module) and reload the page.

If the user cancels the prompt, display the standard about:neterror
"Unable to connect" page. This requires a small change to
browser/actors/NetErrorChild.jsm to account for the fact that the
docShell no longer has the failedChannel information. The failedChannel
is used to extract TLS-related error info, which is not applicable
in the case of a canceled .onion authentication prompt.

Add a leaveOpen option to PopupNotifications.show so we can display
error messages within the popup notification doorhanger without
closing the prompt.

Add support for onion services strings to the TorStrings module.

Add support for Tor extended SOCKS errors (Tor proposal 304) to the
socket transport and SOCKS layers. Improved display of all of these
errors will be implemented as part of bug 30025.

Also fixes bug 19757:
 Add a "Remember this key" checkbox to the client auth prompt.

 Add an "Onion Services Authentication" section within the
 about:preferences "Privacy & Security section" to allow
 viewing and removal of v3 onion client auth keys that have
 been stored on disk.

Also fixes bug 19251: use enhanced error pages for onion service errors.

Marco Simonelli authored 2 years ago and Pier Angelo Vendrame committed 1 year ago

- properly define NOMINMAX for just MSVC builds

Jon Coppeard authored 2 years ago and Pier Angelo Vendrame committed 1 year ago

Bug 1816158 - Part 2: Require no GC when giving out references to the realm's debugger vector r=sfink

To prevent any other instances of this problme we can update the getDebuggers()
methods on the global and the realm to require no GC.

Depends on D169701

Differential Revision: https://phabricator.services.mozilla.com/D169702

Jon Coppeard authored 2 years ago and Pier Angelo Vendrame committed 1 year ago

GC can mutate this vector so don't allow that while we are iterating. I think
it would be safe to use index-based iteration but it's safer to just ban it
entirely.

This fixes the crash produced by the testcase.

Differential Revision: https://phabricator.services.mozilla.com/D169701

Bug 1752703 - Move the pthread_thread_create() interposer under mozglue and prepare for having a single place where we place interposer functions r=glandium a=RyanVM

Differential Revision: https://phabricator.services.mozilla.com/D164470

BaseCompiler::emitCatch will push `tag.params().length() + 1` entries
to the Stk.

Differential Revision: https://phabricator.services.mozilla.com/D178220

Differential Revision: https://phabricator.services.mozilla.com/D176300

Differential Revision: https://phabricator.services.mozilla.com/D176031

Bug 1645865 - Increase the distance to stack size limit when setting new document on a window. r=nika,tcampbell a=RyanVM

Differential Revision: https://phabricator.services.mozilla.com/D174766

Differential Revision: https://phabricator.services.mozilla.com/D174766

Differential Revision: https://phabricator.services.mozilla.com/D173440

Bug 1824301: Update time zone data to tzdata2023a (ESR102 backport). r=#platform-i18n-reviewers!, a=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D173658

Original Revision: https://phabricator.services.mozilla.com/D173171

Differential Revision: https://phabricator.services.mozilla.com/D173995

Differential Revision: https://phabricator.services.mozilla.com/D173136

The latter relies on being able to access the former.

Differential Revision: https://phabricator.services.mozilla.com/D171723

Differential Revision: https://phabricator.services.mozilla.com/D170909

Differential Revision: https://phabricator.services.mozilla.com/D169274

Bug 1804493 - Remove the PDIR mechanism formerly used for Windows compatibility. r=jmaher, a=release

Bug 1811939 - Check whether module load request was already cancelled when a load fails r=smaug a=pascalc

Differential Revision: https://phabricator.services.mozilla.com/D167927

Differential Revision: https://phabricator.services.mozilla.com/D167105

Differential Revision: https://phabricator.services.mozilla.com/D159517

Differential Revision: https://phabricator.services.mozilla.com/D163570

Bug 1774111 - Check for already-completed request in ModuleLoaderBase::FinishDynamicImport r=yulia, a=RyanVM

I've looked at this for a while and still don't know how this can happen but it
does seem reasonable to add a check here that we haven't already completed the
request.

Depends on D162386

Differential Revision: https://phabricator.services.mozilla.com/D162387

We're getting a bunch of crashes related to initializing AutoJSAPI from a
JSObject pointer that turns out to be null. That overload of Init() gets the
native global from the JSObject and since we already have a native global in
the module loader we can use the overload that takes that instead. This
overload does a null check so we will catch the case where the global is null
(although that should also not happen).

This might just move crashes elsewhere but it's a reasonable tidyup.

Differential Revision: https://phabricator.services.mozilla.com/D162386

Differential Revision: https://phabricator.services.mozilla.com/D161087

Bug 1798623: Update time zone data to tzdata2022f (ESR102 backport). r=#platform-i18n-reviewers, a=dmeehan


Backport for ESR102.

Differential Revision: https://phabricator.services.mozilla.com/D161009

Bug 1798623: Update time zone data to tzdata2022f (ESR102 backport). r=#platform-i18n-reviewers, a=dmeehan


Backport for ESR102.

Differential Revision: https://phabricator.services.mozilla.com/D161009

Bug 1796901 - Clear realm incremental marking state at the start of GC rather than at the end r=jandem, a=dmeehan

GC can be aborted in several states and zones GCRuntime::finishCollection
doesn't always get called. It's easier to clear this state in a signle place at
the start.

Differential Revision: https://phabricator.services.mozilla.com/D160056

When marking a BaseShape we mark its global, and we read the pointer to that
global from the realm. If a realm doesn't have a live global we can sweep the
realm but there may still be pointers to it in base shapes and these are left
dangling.

This happens when we hit OOM while creating a global during an incremental GC.
The BaseShape survives because it was allocated after the start of the GC. The
global itself is never successfully created and so the realm doesn't have a
live global and is swept. In this case, we trigger UAF when we try to compact
the heap and trace the base shape.

The patch adds an extra case for keeping a realm alive if it was created during
an incremental GC. This matches the way that GC things are not collected if
they are allocated after the start of a GC.

Differential Revision: https://phabricator.services.mozilla.com/D158022

Differential Revision: https://phabricator.services.mozilla.com/D157735

It's pretty confusing that this name is sometimes used for local variables and
sometimes refers to the current mark color.

Depends on D157733

Differential Revision: https://phabricator.services.mozilla.com/D157734

Delayed marking may push more (normal, non-delayed) marking work. We need to do
this before switch mark color from black to gray since we cannot add gray
marking work while there is black marking work on the stack.

Differential Revision: https://phabricator.services.mozilla.com/D157733

Differential Revision: https://phabricator.services.mozilla.com/D157612

Differential Revision: https://phabricator.services.mozilla.com/D156605

Differential Revision: https://phabricator.services.mozilla.com/D152305

Differential Revision: https://phabricator.services.mozilla.com/D152304

Differential Revision: https://phabricator.services.mozilla.com/D155068