When sandboxing is enabled, we could not write any stats to disk.
check_or_create_data_subdir("stats"), which prepares the private stats
directory, calls check_private_dir(), which also opens and not just stats() the
directory.  Therefore, we need to also allow open() for the stats dir in our
sandboxing setup.

teor (Tim Wilson-Brown) authored 8 years ago and Nick Mathewson committed 8 years ago

If we manually remove fallbacks in C by adding '/*' and '*/' on separate
lines, stem still parses them as being present, because it only looks at
the start of a line.

Add a comment to this effect in the generated source code.

Comment-only change

No behavioural change.
Also clarify some comments.

The previous version of the new accessors didn't specify const but it
was changed in master.

The IPv4-only entry will be used for 0.2.8.
The IPv4 and IPv6 entry will be considered in 0.2.9.

The operator has confirmed that the DirPort change is perament.
The relay will be reconsidered as a fallback in 0.2.9.

Blacklist them in case they appear again.

Leave these fallbacks in the whitelist, they may improve before 0.2.9.

Remove a fallback that changed its fingerprint after it was listed
This happened after to a software update:
https://lists.torproject.org/pipermail/tor-relays/2016-June/009473.html

Remove a fallback that changed IPv4 address

Remove two fallbacks that were slow to deliver consensuses,
we can't guarantee they'll be fast in future.

Blacklist all these fallbacks until operators confirm they're stable.

Operators have sent emails asking to have their relays added or
removed from the fallback list. Since none of the blacklisted
relays are in the hard-coded falback list, it does not need to
be changed.

George Kadianakis authored 8 years ago and Nick Mathewson committed 8 years ago

Callbacks can't return 0.

Another part of 19406

Yawning Angel authored 8 years ago and Nick Mathewson committed 8 years ago

Just as it says on the tin.  Don't need to fully disable any tests and
reduce coverage either.  Yay me.

Yawning Angel authored 8 years ago and Nick Mathewson committed 8 years ago

This is a logging onlu change, we were suppressing the severity down to
INFO when it occured (treating it as "Mostly harmless").  Now it is no
more.

Yawning Angel authored 8 years ago and Nick Mathewson committed 8 years ago

There's accessors to get at things, but it ends up being rather
cumbersome.  The only place where behavior should change is that the
code will fail instead of attempting to generate a new DH key if our
internal sanity check fails.

Like the previous commit, this probably breaks snapshots prior to pre5.

Yawning Angel authored 8 years ago and Nick Mathewson committed 8 years ago

Instead of `ERR_remove_thread_state()` having a modified prototype, it
now has the old prototype and a deprecation annotation.  Since it's
pointless to add extra complexity just to remain compatible with an old
OpenSSL development snapshot, update the code to work with 1.1.0pre5
and later.

Previously, we used !directory_fetches_from_authorities() to predict
that we would tunnel connections.  But the rules have changed
somewhat over the course of 0.2.8

Fixes the 0.2.7 case of bug #19213, which prevented mingw64 from
working.