isolate favicon requests and caching by URL bar domain

Favicon images are requested by the tab element inside the main chrome window, so we need a patch to make sure they are isolated by the first party domain of the loading document. This ticket has been spun off from #13670 (moved).

added TorBrowserTeam201507R component::applications/tor browser ff38-esr owner::boklm priority::medium resolution::fixed status::closed tbb-testcase type::defect labels

Here's my latest patch for review (against FF38-ESR): https://github.com/arthuredelstein/tor-browser/commits/13670_favicons

Please note that this needs to by applied after the #13670 (moved) OCSP patch.

Trac:
Status: new to needs_review

This patch looks OK to me. We should make sure to add tests both for default favicons, as well as favicons specified in HTML (as the latter may change if the OwnerDoc is chrome).

Transfer review tickets to next month.

Trac:
Keywords: TorBrowserTeam201506R deleted, TorBrowserTeam201507R added

Trac:
Keywords: N/A deleted, tbb-testcase added

arthur - Can you and boklm work out who will write the test cases for this? I think we should cover both HTML and default favicons in the tests. Not sure if that means it requires a full integration test or if it can still be done with a unit test... If we do decide we need a heavyweight integration test, perhaps we should cover OCSP too?

Trac:
Cc: mikeperry, gk to mikeperry, gk, boklm
Status: needs_review to needs_revision

I can add that (the test) to my TODO list.

Trac:
Cc: mikeperry, gk, boklm to mikeperry, gk, boklm, arthuredelstein
Status: needs_revision to assigned
Owner: tbb-team to boklm

I filed #16728 (moved) for the test cases. Closing this ticket.

Trac:
Status: assigned to closed
Resolution: N/A to fixed

closed

mentioned in issue #16728 (moved)

moved to tpo/applications/tor-browser#16448 (closed)

mentioned in issue tpo/applications/tor-browser#16728 (closed)