Skip to content
Snippets Groups Projects

Make tor_check_port_forwarding handle incomplete lines

    • Closed (moved) Issue created by Steven Murdoch @sjm217

    The code for parsing the output of tor-fw-helper uses fgets() on a non-blocking file descriptor to fetch each line of output. This appears to not handle incomplete lines properly. Rather than buffering data until a complete line is returned, fgets will return an incomplete line and set errno to be EAGAIN. fgets() should be replaced with something which can handle incomplete lines.

    Issue was originally raised by nickm in bug #1903 (moved) and there is some further discussion in that ticket.

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    Please register or sign in to reply