Make windows log_from_handle() handle partial lines

See legacy/trac#2045 (moved) for a full description of the problem. With legacy/trac#21654 (moved), we fixed the unix case, but the windows case may remain.

changed milestone to %Tor: unspecified in legacy/trac

added component::core tor/tor in Legacy / Trac ipc in Legacy / Trac milestone::Tor: unspecified in Legacy / Trac priority::medium in Legacy / Trac severity::normal in Legacy / Trac status::new in Legacy / Trac tor-client in Legacy / Trac type::defect in Legacy / Trac win32 in Legacy / Trac windows in Legacy / Trac labels

Trac:
Keywords: tor-client windows deleted, tor-client windows ipc added

Trac:
Keywords: tor-client windows ipc deleted, tor-client windows ipc win32 added

moved from legacy/trac#22380 (moved)

added Bug label and removed 1 deleted label

added Client Windows labels and removed 1 deleted label

added First Contribution label

removed milestone

added Icebox label

I wonder if this is an issue that @tpo/anti-censorship has been hitting?

I'm not sure what kind of visible behavior will this bug produce. But I haven't read any reports of specific problems in windows, so I guess we are not hitting this or maybe windows users just don't complain much.

added Triage2022 label

d3b9b5a3 removed log_from_handle, due to:

This function was only used by PortForwardingHelper, which was removed in 9df110cd. Its presence caused warnings on windows.

it seems that this problem has been resolved?

Ah, great. I hoped it might be. Closing.

closed