node_get_ed25519_id() should check if the microdesc ed25519 id is all zero

Currently we only do this for the ri ed25519 id. If that check is already done when we parse microdescs, we should add a comment.

changed milestone to %Tor: 0.3.3.x-final

added component::core tor/tor easy intro milestone::Tor: 0.3.3.x-final points::0.5 priority::medium resolution::implemented severity::normal status::closed type::enhancement labels

Agree with this. It would help to have a stronger assumption on the returned key that it is in fact valid (non zero) all the time.

Trac:
Keywords: N/A deleted, easy intro added

Maybe we should do this as part of the consistency changes in #23975 (moved).

Trac:
Parent: N/A to #23975 (moved)

Replying to teor:

Currently we only do this for the ri ed25519 id. If that check is already done when we parse microdescs, we should add a comment. I think the check happens, only a comment is required.

Trac:
Username: aruna1234

Trac:
Username: aruna1234

0001-Bug-24001-Comment-added-regarding-the-function.patch

Trac:
Username: aruna1234

In C, doing an "if (ptr)" check on a pointer checks whether the pointer is NULL, not whether the memory that the pointer points to is zero.

I think it would be a good idea to check both the ri and md ed25519 ids to see if the memory they point to is zero.

Can you copy the check from the ri ed25519 id to the md ed25519 id?

Trac:
Status: new to needs_revision

Replying to nickm:

In C, doing an "if (ptr)" check on a pointer checks whether the pointer is NULL, not whether the memory that the pointer points to is zero.

If that's the case then I think this would work: if(*(node->ri))

Trac:
Username: aruna1234

That checks if the first byte of the object is zero. We need to check if every byte is zero. We have a function for that, I think it's called tor_mem_is_zero().

Replying to teor:

That checks if the first byte of the object is zero. We need to check if every byte is zero. We have a function for that, I think it's called tor_mem_is_zero(). I added this, if(tor_mem_is_zero((char*)node->md, sizeof(node->md->ed25519_identity_pkey)))

however it is failing when I do a make check at src/test/test.

Trac:
Username: aruna1234

Replying to teor:

I think it would be a good idea to check both the ri and md ed25519 ids to see if the memory they point to is zero.

Can you copy the check from the ri ed25519 id to the md ed25519 id? also did this,

if (BUG(ed25519_public_key_is_zero(md_pk))) md_pk = NULL; this is passing all tests when I run a make check

Trac:
Username: aruna1234

Please attach a working patch that contains all your changes

Trac:
Username: aruna1234

0001-Conditional-check-added.patch

Trac:
Username: aruna1234

Please see my branch ticket24001 at https://github.com/teor2345

I moved and expanded the comment, and added a changes file.

Trac:
Status: needs_revision to needs_review
Type: defect to enhancement

Trac:
Status: needs_review to merge_ready

(This is unrelated to #23975 (moved).)

Trac:
Parent: #23975 (moved) to N/A

Replying to teor:

Please see my branch ticket24001 at https://github.com/teor2345

I moved and expanded the comment, and added a changes file. okay!

Trac:
Username: aruna1234

merged to master!

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

changed time estimate to 4h

mentioned in issue #24002 (moved)

moved to tpo/core/tor#24001 (closed)

mentioned in issue tpo/core/tor#24002 (closed)