node_get_ed25519_id() should check if the microdesc ed25519 id is all zero
Currently we only do this for the ri ed25519 id. If that check is already done when we parse microdescs, we should add a comment.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- teor changed milestone to %Tor: 0.3.3.x-final in legacy/trac
changed milestone to %Tor: 0.3.3.x-final in legacy/trac
- teor added component::core tor/tor in Legacy / Trac easy in Legacy / Trac intro in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac points::0.5 in Legacy / Trac priority::medium in Legacy / Trac resolution::implemented in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels
added component::core tor/tor in Legacy / Trac easy in Legacy / Trac intro in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac points::0.5 in Legacy / Trac priority::medium in Legacy / Trac resolution::implemented in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels
- Owner
Agree with this. It would help to have a stronger assumption on the returned key that it is in fact valid (non zero) all the time.
Maybe we should do this as part of the consistency changes in legacy/trac#23975 (moved).
Trac:
Parent: N/A to legacy/trac#23975 (moved)Trac:
Username: aruna1234- Owner
In C, doing an "if (ptr)" check on a pointer checks whether the pointer is NULL, not whether the memory that the pointer points to is zero.
Replying to teor:
That checks if the first byte of the object is zero. We need to check if every byte is zero. We have a function for that, I think it's called tor_mem_is_zero(). I added this, if(tor_mem_is_zero((char*)node->md, sizeof(node->md->ed25519_identity_pkey)))
however it is failing when I do a make check at src/test/test.
Trac:
Username: aruna1234Replying to teor:
I think it would be a good idea to check both the ri and md ed25519 ids to see if the memory they point to is zero.
Can you copy the check from the ri ed25519 id to the md ed25519 id? also did this,
if (BUG(ed25519_public_key_is_zero(md_pk))) md_pk = NULL; this is passing all tests when I run a make check
Trac:
Username: aruna1234Trac:
Username: aruna1234Please see my branch ticket24001 at https://github.com/teor2345
I moved and expanded the comment, and added a changes file.
Trac:
Status: needs_revision to needs_review
Type: defect to enhancement(This is unrelated to legacy/trac#23975 (moved).)
Trac:
Parent: legacy/trac#23975 (moved) to N/AReplying to teor:
Please see my branch ticket24001 at https://github.com/teor2345
I moved and expanded the comment, and added a changes file. okay!
Trac:
Username: aruna1234- Owner
merged to master!
Trac:
Status: merge_ready to closed
Resolution: N/A to implemented - Trac closed
closed
- Trac changed time estimate to 4h
changed time estimate to 4h
- teor mentioned in issue legacy/trac#24002 (moved)
mentioned in issue legacy/trac#24002 (moved)
- Trac moved from legacy/trac#24001 (moved)
moved from legacy/trac#24001 (moved)
- Trac added Feature First Contribution labels and removed 1 deleted label
added Feature First Contribution labels and removed 1 deleted label
- Trac removed 1 deleted label
removed 1 deleted label