Trac:
Cc: N/A to gk

The fetch API is still disabled in ESR 38: https://bugzilla.mozilla.org/show_bug.cgi?id=1133861.

Tag the set of things we should have implemented before a full 5.0 launch, and add them to the July radar.

Trac:
Keywords: N/A deleted, tbb-5.0a, TorBrowserTeam201507 added

Trac:
Cc: gk to gk, mcs, brade

The Fetch API is off by default until Firefox 39. We can turn it on for testing by setting "dom.enabled.fetch" to true in FF 38. Weirdly, I can't get fetch(...) to cache the responses it receives, even if I include the option {cache: "force-cache"}.

Ah, the same pref covers both fetch() and Request. Pushing this out to ff45-esr.

Trac:
Keywords: ff38-esr, TorBrowserTeam201507, tbb-5.0a deleted, ff45-esr added

Replying to arthuredelstein:

The Fetch API is off by default until Firefox 39. We can turn it on for testing by setting "dom.enabled.fetch" to true in FF 38. Weirdly, I can't get fetch(...) to cache the responses it receives, even if I include the option {cache: "force-cache"}.

Even more weird... the response apparently is cached. I wrote a simple example: https://arthuredelstein.github.io/tordemos/fetch-caching.html

On the network panel of the developer console, I can see a 304 (not modified) response on the second load after clearing the cache. However, the fetched file does not appear in about:cache anywhere. So there's something odd going on.

I'm going to postpone further work on this until ff45-esr.

Trac:
Keywords: N/A deleted, tbb-6.0a5 added

Trac:
Status: new to accepted
Cc: gk, mcs, brade to gk, mcs, brade, arthuredelstein
Reviewer: N/A to N/A
Owner: tbb-team to arthuredelstein
Sponsor: N/A to N/A
Severity: N/A to Normal

We want that for the alpha and the ESR 45 stable series.

Trac:
Keywords: N/A deleted, TorBrowserTeam201604 added

Here's a patch for review that provides regression tests for first-party cache isolation with fetch: https://github.com/arthuredelstein/tor-browser/commit/72de4dd2ec86517f3707fb2159876464291544ca

(Note this 16326+2 branch also contains a commit to fix #18741 (moved). Once both commits are applied, then all the tests in ./mach mochitest netwerk/test/browser/browser_cacheFirstParty.js pass.)

Trac:
Keywords: TorBrowserTeam201604 deleted, TorBrowserTeam201604R added
Status: accepted to needs_review

I have updated this work, here: #18741 (moved)::comment:8 Please disregard the version in comment:11 of this ticket.

Fixed with commit 3560a0c1a998f1e875e06bea15fb3d1203da385e on tor-browser-45.0.2esr-6.x-1, thanks!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed