What version of Rust does Tor require for 0.3.2?

On #24761 (moved), Sebastian says that we require Rust 1.14, but I can't see that documented anywhere.

We should document it:

• in the release notes
• in the wiki: https://trac.torproject.org/projects/tor/wiki/RustInTor

And point to it from:

• https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStartedRust.md

And document the nightly/feature thing in our coding standards:

• https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandardsRust.md

changed milestone to %Tor: 0.3.3.x-final

added actualpoints::0.1 component::core tor/tor doc milestone::Tor: 0.3.3.x-final owner::nickm points::0.1 priority::medium resolution::implemented rust severity::normal status::closed type::task labels

We actually require Rust 1.18 for HashSet retain in protover.rs.

Trac:
Description: On #24761 (moved), Sebastian says that we require Rust 1.14, but I can't see that documented anywhere.

We should document it:

• in the release notes
• in the wiki: https://trac.torproject.org/projects/tor/wiki/RustInTor

And point to it from:

• https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStartedRust.md

And document the nightly/feature thing in our coding standards:

• https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandardsRust.md

to

On #24761 (moved), Sebastian says that we require Rust 1.14, but I can't see that documented anywhere.

We should document it:

• in the release notes
• in the wiki: https://trac.torproject.org/projects/tor/wiki/RustInTor

And point to it from:

• https://gitweb.torproject.org/tor.git/tree/doc/HACKING/GettingStartedRust.md

And document the nightly/feature thing in our coding standards:

• https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandardsRust.md

When we started out we wanted to require 1.14 because that is available in Debian. I guess we never documented it properly, and thus it got broken. But if our CI can build with newer Rust then we should probably just use that

I am in favor of requiring the most recent rust that we can "get away with" requiring.

These bugfix tickets have no patches. The earliest they will get done is 0.3.3.

Trac:
Milestone: Tor: 0.3.2.x-final to Tor: 0.3.3.x-final

Closed #25379 (moved) as a duplicate of this.

Replying to nickm:

I am in favor of requiring the most recent rust that we can "get away with" requiring.

We can probably get away with the whatever the current nightly is? and then cease and track it to stable when we hear of a major distro that we care about has a new release including it, since Rust releases are quite rapid (6 weeks) and distros are generally quite slow to stabilise. One negative implication of this is we won't be able to use any #[feature]s, ever, or we'll likely have a bad time later trying to ask Rust devs for our features to be stabilised super fast into whichever version we're using that will become stable.

Probably we should at least change configure.ac to check for 1.18, given the HashSet problem that teor noted above.

Consolidating the tags

Trac:
Keywords: tor-rust deleted, rust added

"Latest nightly" makes me pretty nervous, but I think "latest stable" isn't too bad.

In Rome I talked to Ximin about Debian's Rust packaging, and learned that Debian is apparently tracking latest stable too, so we probably won't get forced to freeze a rust version until the next Debian release starts to freeze.

Trac:
Status: new to accepted
Owner: N/A to nickm

We didn't mention a version in the RustInTor wiki pake earlier, so I'm not adding one there. I'll write a patch for the other stuff though.

I've done a minimal version of this in 74c767af29e793749e697eba8a206850b156521e, and merged it (since it's docs-only) to 0.3.3 and forward.

Trac:
Status: accepted to closed
Resolution: N/A to implemented

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #25379 (moved)

mentioned in issue #25379 (moved)

mentioned in issue #25714 (moved)

mentioned in issue #27160 (moved)

moved to tpo/core/tor#24765 (closed)

mentioned in issue tpo/core/tor#25714 (closed)

mentioned in issue tpo/core/tor#27160 (closed)