I tried to fix this. Here is my github branch: https://github.com/Jigsaw52/tor/tree/fix-19562

I named the argument of the voting_schedule_free as voting_schedule_to_free because naming it voting_schedule would shadow an existing variable on dirvote.c.

Trac:
Status: new to needs_review

For a public function that is non-static, I personally prefer having the object name before the action so voting_schedule_free() instead. Actually, in this case if we really want to be strict on the namespacing, we should do something like dirvote_voting_schedule_free() (or dir_) but I'll leave this decision to nickm on what he prefers (as the maintainer) :)

Apart from naming, lgtm!

Trac:
Status: needs_review to merge_ready
Reviewer: N/A to dgoulet

If it's merge_ready we can take the time in 0.2.9. (it comes from a volunteer after all)

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.2.9.x-final

Agreed with dgoulet; doing a search-and-replace then merging.

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed