Rust tests don't fail on failure

Apparently, at least some versions of find won't fail when they exec something that fails. How delightful!

This means that our fix for #25560 (moved) isn't right. I'll try another here -- just a moment...

changed milestone to %Tor: 0.3.4.x-final

added 033-backport 034-must component::core tor/tor milestone::Tor: 0.3.4.x-final owner::nickm priority::medium regression resolution::fixed reviewer::catalyst severity::normal status::closed type::defect labels

Trac:
Owner: N/A to nickm
Status: new to accepted

See my branch bug26258_033 ?

Trac:
Status: accepted to needs_review

Trac:
Reviewer: N/A to catalyst

Fails in Travis in cargo offline mode. Failure replicates when manually run. Maybe some Cargo.lock files need updating, or the external deps repo needs updating?

https://api.travis-ci.org/v3/job/387272070/log.txt

FAIL: src/test/test_rust.sh
===========================

error: attempting to make an HTTP request, but --frozen was specified
error: attempting to make an HTTP request, but --frozen was specified
error: attempting to make an HTTP request, but --frozen was specified
error: attempting to make an HTTP request, but --frozen was specified
error: attempting to make an HTTP request, but --frozen was specified
error: attempting to make an HTTP request, but --frozen was specified

Trac:
Status: needs_review to needs_revision

So, the good news here is that this bug isn't mine: it's already present in Tor! The solution is to run Cargo from inside the corresponding directory.

I've updated my bug26258_033 branch, and pushed it to github too with https://github.com/torproject/tor/pull/149

Trac:
Status: needs_revision to needs_review

Looks good to me!

Trac:
Status: needs_review to merge_ready

Woo; merged to 0.3.3 and forward!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

There was a bug: I should have said ${CARGO_ONLINE-"--frozen}, not ${CARGO_ONLINE:-"--frozen"}

The former treats an empty setting ("") as set, whereas the latter does not.

Trac:
Resolution: fixed to N/A
Status: closed to reopened

ccf1eb3164a48de042dfdd8712f4b788bfefdc49 fixes this.

Trac:
Resolution: N/A to fixed
Status: reopened to closed

closed

mentioned in issue #26373 (moved)

mentioned in issue #26378 (moved)

mentioned in issue #26455 (moved)

moved to tpo/core/tor#26258 (closed)

mentioned in issue tpo/core/tor#26373 (closed)

mentioned in issue tpo/core/tor#26378 (closed)

mentioned in issue tpo/core/tor#26455 (closed)