Support default dark-theme for the Circuit Display UI

Let's do the necessary small tweaks to support our UI for the default dark-theme:

• Remove background
• Use the light version of the Tor icon
• Use a light grey at the circuit graph lines
• Guard needs to have #D476FF
• At the bottom area, remove the background. It is going to make the helper text visible.

Attaching TB 9.0a6 screenshot

Trac:
Child Ticket(s): #29164 (moved)

added TorBrowserTeam201910R actualpoints::1.1 component::applications/tor browser ff68-esr owner::tbb-team points::1 priority::medium resolution::fixed reviewer::antonela severity::normal status::closed tbb-9.0-must-alpha type::defect ux-team labels

Trac:

Should we resolve #31656 (moved) as duplicate?

Note, there is #31658 (moved) as well, which is kind of related.

Ohh, pospeselr won me in that one. I closed #31656 (moved) as duplicate.

Trac:
Points: N/A to 1

Trac:
Keywords: N/A deleted, TorBrowserTeam201910 added

Trac:
Keywords: TorBrowserTeam201909 deleted, N/A added

Trac:

Trac:

Trac:

For review: https://github.com/acatarineu/torbutton/commit/31778.

I'm attaching three screenshots, with default being the one with system colors (dark in my case), and the other two dark and light. I was not sure whether #D476FF color had to be applied only for Dark mode or for both. I tried to only apply for dark-mode via -moz-lwtheme-brighttext, however that does not seem to work for the default theme when the system is using dark mode (see screenshot). Is this ok or should we change the colors somehow?

Trac:
Actualpoints: N/A to 1
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201910R added
Status: assigned to needs_review

Replying to acat:

I'm attaching three screenshots, with default being the one with system colors (dark in my case), and the other two dark and light.

Thanks for it!

I was not sure whether #D476FF color had to be applied only for Dark mode or for both. Just dark mode. That color is coming from #27200 (moved) so maybe you already have that rule somewhere.

I tried to only apply for dark-mode via -moz-lwtheme-brighttext, however that does not seem to work for the default theme when the system is using dark mode (see screenshot). Is this ok or should we change the colors somehow? We are OK!

We need to have lightgrey at the circuit display link [Learn More].

https://trac.torproject.org/projects/tor/raw-attachment/ticket/31778/dark-theme.png

Trac:
Keywords: TorBrowserTeam201910R deleted, TorBrowserTeam201910 added
Status: needs_review to needs_revision

Trac:

Revised adding a dark gray for the 'Learn more' link: https://github.com/acatarineu/torbutton/commit/31778+1.

Trac:
Status: needs_revision to needs_review
Actualpoints: 1 to 1.1
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201910R added

Looks good to me, nice work. Cherry-picked to master (commit ad8abfab6030a92d3893166f0ba3bc33b186122). Should be available in tomorrow's nightly builds.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

changed time estimate to 8h

added 8h 48m of time spent

mentioned in issue #29164 (moved)

moved to tpo/applications/tor-browser#31778 (closed)