No need to disable GeckoDriver in Windows mozconfig files

We compile with --disable-tests on Windows which automatically disables GeckoDriver. Thus, we can clean up our mozconfig files a bit.

added GeorgKoppen201912 TorBrowserTeam202001R component::applications/tor browser owner::tbb-team points::0.1 priority::medium resolution::fixed reviewer::boklm severity::normal status::closed type::defect labels

bug_32700 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32700&id=40502c9d0abb4e2c6b732162536fd2ea26bfe35b) has the patch for review.

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201912 deleted, TorBrowserTeam201912R added

Child of #4280 (moved).

ac_add_options --enable-default-toolkit=cairo-windows is not needed too.

mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" - Mozilla and TBA don't set it that way, and you should not.

A new line is needed after ac_add_options --disable-eme, because of the comment above it.

# Disable telemetry-># Disable telemetry reporting. # Disable telemetry is #32493 (moved).

Trac:
Keywords: TorBrowserTeam201912R deleted, TorBrowserTeam202001R added

No December anymore.

Trac:
Keywords: GeorgKoppen201912 deleted, GeorgKoppen202001 added

Trac:
Keywords: GeorgKoppen202001 deleted, GeorgKoppen201912 added

Trac:
Reviewer: N/A to boklm

Replying to cypherpunks:

Child of #4280 (moved).

ac_add_options --enable-default-toolkit=cairo-windows is not needed too.

mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser" - Mozilla and TBA don't set it that way, and you should not.

Please open separate tickets for those issues.

Replying to gk:

bug_32700 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_32700&id=40502c9d0abb4e2c6b732162536fd2ea26bfe35b) has the patch for review.

This looks good to me. I merged the patch to master with commit b1690c3404c0454cb805a01e94e7d45e74ad17e0.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

changed time estimate to 48m

moved to tpo/applications/tor-browser#32700 (closed)