Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #33665

Closed (moved)
Open
Opened Mar 19, 2020 by David Fifield@dcf

Add command-line options for unsafe logging

Moved from comment:4:ticket:33157

Something like that patch was useful when working on #19026 (moved) so would you consider merging, https://github.com/keroserene/snowflake/commit/dbd733e4b1430c046ec11e8052efdbac6010e58a

It's okay with me but I would call the option --unsafe-logging instead of --unsafeLogging to match the style of the other options.

In broker/broker.go, yes, dashes are used (ex. disable-tls, acme-email, etc), however, in client/snowflake.go we have camel casing (ex. logToStateDir, keepLocalAddresses, etc)

We should probably consolidate this now. I imagine your preference is for the former?

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#33665