specifically, specify what sort of routers we're fetching.

Bugfix for #6732.

Fix for #6251

We are doing this merge to avoid taking the patch from
"nickm/disable_pathbias_warnings_v2" into 0.2.4 -- we're going to try
to fix the pathbias code for real here.

We've had over two months to fix them, and didn't.  Now we need
0.2.3.x stable.  Yes, it would be cool to get this working in
0.2.3.x, but not at the expense of delaying every other feature that
_does_ work in 0.2.3.x.  We can do a real fix in 0.2.4.

Conflicts:
	src/or/policies.c

a router that another router wasn't already connected to.

This can create a remote crash opportunity for/against directory
authorities.

This is important, since otherwise an attacker can use timing info
to probe the internal network.

Also, add an option (ExtendAllowPrivateAddresses) so that
TestingTorNetwork won't break.

Fix for bug 6710; bugfix on all released versions of Tor.

Jim Meyering authored 12 years ago and Nick Mathewson committed 12 years ago

(commit message by nickm)

This comes at the cost of making its failure message a little less
friendly, but since when do assertion failures count as
user-friendly?

Automake 1.7 is too broken to even investigate why it broke at this point.

We were effectively resetting our counts, and the rounding error
leads to incorrect log messages.

Also make a couple of them less scary.

We'll do a separate, additional commit on 0.2.4.x to bump them back
up again.

This should eliminate a lot of notices for Directory Authorities and other
situations where circuits built without using guard nodes.