Previously, we were also considering the time spent in
soft-hibernation.  If this was a long time, we would wind up
underestimating our bandwidth by a lot, and skewing our wakeup time
towards the start of the accounting interval.

This patch also makes us store a few more fields in the state file,
including the time at which we entered soft hibernation.

Fixes bug 1789.  Bugfix on 0.0.9pre5.

This should help address bug 1789.

Setting CookieAuthFileGroupReadable but without setting CookieAuthFile makes
no sense, because unix directory permissions for the data directory prevent
the group from accessing the file anyways.

Incidentally fixes bug 1042.

Conflicts:
	src/or/reasons.c

Sebastian Hahn authored 14 years ago and Nick Mathewson committed 14 years ago

(Partial backport of 150ed553, 161b2750, and 4c948ffd.)

Conflicts:
	src/or/rephist.h

Also remove some #if 0'd code from the unit tests for buffers. The
code was killed in e6794e58 (5 years
ago), and is now broken anyways.

Resolved conflict in
	src/or/networkstatus.c

If the voting interval was short enough, the two-minutes delay
of CONSENSUS_MIN_SECONDS_BEFORE_CACHING would confuse bridges
to the point where they would assert before downloading a consensus.
It it was even shorter (<4 minutes, I think), caches would
assert too.  This patch fixes that by having replacing the
two-minutes value with MIN(2 minutes, interval/16).

Bugfix for 1141; the cache bug could occur since 0.2.0.8-alpha, so
I'm calling this a bugfix on that.  Robert Hogan diagnosed this.
Done as a patch against maint-0.2.1, since it makes it hard to
run some kinds of testing networks.

Karsten Loesing authored 14 years ago and Nick Mathewson committed 14 years ago

Fixes 1832; bugfix on 0.2.2.6-alpha