patch from rubiate on #16651

Yawning Angel authored 9 years ago and Nick Mathewson committed 9 years ago

Implements feature #13696.

There was a dead check when we made sure that an array member of a
struct was non-NULL.  Tor has been doing this check since at least
0.2.3, maybe earlier.

Fixes bug 17781.

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

This commit fixes a memory leak introduced by commit
8b4e5b7e.

Previously we'd suppressed the mask-bits field in the output when
formatting a policy if it was >=32.  But that should be a >=128 if
we're talking about IPv6.

Since we didn't put these in descriptors, this bug affects only log
messages and controller outputs.

Fix for bug 16056.  The code in question was new in 0.2.0, but the
bug was introduced in 0.2.4 when we started supporting IPv6 exits.

connection_get_by_type_addr_port_purpose also ignores connections
that are marked for close.

port is in host order (addr is tor_addr_t, endianness is abstracted).

addr and port can be different to conn->addr and conn->port if
connecting via a proxy.

Consistently ignore multicast addresses when automatically
generating reject private exit policies.

Closes ticket 17763. Bug fix on 10a6390d,
not in any released version of Tor. Patch by "teor".

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

The tor_cert_get_checkable_sig function uses the signing key included in
the certificate (if available) when a separate public key is not given.

When the signature is valid, the tor_cert_checksig function copies the
public key from the checkable structure to the public key field of the
certificate signing key.

In situations where the separate public key is not given but the
certificate includes a signing key, the source and destination pointers
in the copy operation are equal and invoke undefined behavior.

Undefined behaviour is avoided by ensuring both pointers are different.

Closes ticket 17724. Bug fix on ade50058 and 5e9f2384,
not in any released version of Tor. Patch by "teor".