We want to be saying fast_mem{cmp,eq,neq} when we're doing a
comparison that's allowed to exit early, or tor_mem{cmp,eq,neq} when
we need a data-invariant timing.  Direct use of memcmp tends to imply
that we haven't thought about the issue.

Conflicts:
	src/config/geoip

Conflicts:
	src/or/dns.c

Fixes bug 7663; bug introduced in 42e3c04a.  Not in any
released version of Tor.

This clears up the remaining issue stopping me from closing bug 6297.

Mike Perry authored 12 years ago and Nick Mathewson committed 12 years ago

Also, add a hack Roger suggested where we're more patient if no circuits are
opened yet.

This replaces the old FallbackConsensus notion, and should provide a
way -- assuming we pick reasonable nodes! -- to give clients
suggestions of placs to go to get their first consensus.

Now creating a dir_server_t and adding it are separate functions, and
there are frontend functions for adding a trusted dirserver and a
fallback dirserver.

We use trusted_dir_server_t for two pieces of functionality: a list of
all directory authorities, and a list of initial places to look for
a directory.  With this patch we start to separate those two roles.

There is as of now no actual way to be a fallback directory without being
an authority.

Fix for bug 7306. Bugfix on 0.2.2.17-alpha.

Fixes bug #7592; bugfix on 882b3896.

The bug is not present in any released versions of Tor.