David Fifield authored 12 years ago and Nick Mathewson committed 12 years ago

This function formats an addr:port pair, and always decorates IPv6
addresses.

David Fifield authored 12 years ago and Nick Mathewson committed 12 years ago

Apparently BridgeDB is already expecting transport lines to be formatted
thus; see https://trac.torproject.org/projects/tor/ticket/7011#comment:12 ff.
It may be that there are no extant IPv6 pluggable transport bridges yet,
so this didn't cause a problem.

David Fifield authored 12 years ago and Nick Mathewson committed 12 years ago

state_transport_line_is_valid calls tor_addr_port_lookup, which expects
brackets around an IPv6 address. Without this, cached transport
addresses can't be parsed later:

[warn] state: Could not parse addrport.
[warn] state: State file seems to be broken.

See #7011.

David Fifield authored 12 years ago and Nick Mathewson committed 12 years ago

This affects the Request-URI and the value of the Host header. RFC 2616
doesn't directly address the formatting of IPv6 addresses, but it
delegates some productions to RFC 2396 "Uniform Resource Identifiers
(URI): Generic Syntax," which is obsoleted by RFC 3986, which requires
square brackets for IPv6 addresses in both places.

I tested this with
	HTTPSProxy 127.0.0.1:8000
	Bridge <IPv6 bridge>
	UseBridges 1
and an Ncat HTTP proxy:
	ncat --proxy-type http -l 8000 -vvv

https://tools.ietf.org/html/rfc2616#section-3.2.1
https://tools.ietf.org/html/rfc2616#section-5.1.2
https://tools.ietf.org/html/rfc2616#section-14.23
https://tools.ietf.org/html/rfc3986#section-3.2.2

They're typically redundant with the "Your computer is too slow"
messages. Fixes bug 7038; bugfix on 0.2.2.16-alpha.

(In retrospect, we should have fixed this bug back in ticket 1042.)

Bitrig is an openbsd fork.  Patch from dhill.  Ticket 6982.

(rather than just always declaring that the reason is
END_CIRC_REASON_OR_CONN_CLOSED)

resolves bug 7039.

In the past we had used reason "internal", which is more vague than
it needs to be. Resolves bug 7037.

resolves bug 7022.

previously we just allocated the string and then freed it.

Patch from 'maker'.

They weren't actually used since 7a35dad0

Bug 5809

Tom Fitzhenry authored 12 years ago and Nick Mathewson committed 12 years ago

bug4020

Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>