Our Windows compiler treats "time_t" as long long int but Linux likes it
long int so cast those to make Windows happy.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Partially fix #23224.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Partially fixes #23223

Signed-off-by: David Goulet <dgoulet@torproject.org>

Use the PATH_SEPARATOR for a path comparaison so it works with Windows as
well.

Partially fix #23223

Signed-off-by: David Goulet <dgoulet@torproject.org>

This change should improve overhead for downloading small numbers of
descriptors and microdescriptors by improving compression
performance and lowering directory request overhead.

Closes ticket 23220.

the values of "v3" and "bridge" have to do with *where* you publish to,
not whether you publish.

Implements 15645.

- Fix various ssize_t/size_t confusions in the tests.

- Fix a weird memset argument:
  "bad_memset: Argument -16 in memset loses precision in
  memset(&desc_two->blinded_kp.pubkey.pubkey, -16, 32UL)."

- Fix check_after_deref instance in check_state_line_for_service_rev_counter():
  "check_after_deref: Null-checking items suggests that it may be null,
  but it has already been dereferenced on all paths leading to the
  check."

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

Add a common function for both legacy and prop224 hidden service to increment
and decrement the rendezvous stream counter on an origin circuit.

Signed-off-by: David Goulet <dgoulet@torproject.org>

David Goulet authored 7 years ago and Nick Mathewson committed 7 years ago

Also, this removes all the callsite of this rephist in the hs subsystem

Fixes #23097

Signed-off-by: David Goulet <dgoulet@torproject.org>

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

Also fix a check-spaces instance.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

Also add some unittests.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

Also add a unittest for hs_get_responsible_hsdirs() which was used to
find and fix the bug.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

Also make sure we are not gonna advertise the ed25519 key of an intro
point that doesn't support it.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

We used to have a small HS desc cert lifetime but those certs can stick
around for 36 hours if they get initialized in the beginning of overlap
period.

[warn] Bug: Non-fatal assertion !(hs_desc_encode_descriptor(desc->desc, &desc->signing_kp, &encoded_desc) < 0) failed in
upload_descriptor_to_hsdir at src/or/hs_service.c:1886. Stack trace: (on Tor 0.3.2.0-alpha-dev b4a14555597fb9b3)

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

I repurposed the old directory_request_set_hs_ident() into a new
directory_request_upload_set_hs_ident() which is only used for the
upload purpose and so it can assert on the dir_purpose.

When coding the client-side we can make a second function for fetch.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

The structure was not zeroed out, and left some boolean fields
uninitialized.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

- Fix some more crazy ternary ops.
- Fix the order of disaster SRV computation.
- Whitespace fixes.
- Remove a redundant warn.
- Better docs.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

We used to do:
   h = H(BLIND_STRING | H(A | s | B | N )
when we should be doing:
   h = H(BLIND_STRING | A | s | B | N)

Change the logic so that hs_common.c does the hashing, and our ed25519
libraries just receive the hashed parameter ready-made. That's easier
than doing the hashing on the ed25519 libraries, since that means we
would have to pass them a variable-length param (depending on whether
's' is set or not).

Also fix the ed25519 test vectors since they were also double hashing.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

We also had to alter the SRV functions to take a consensus as optional
input, since we might be setting our HSDir index using a consensus that
is currently being processed and won't be returned by the
networkstatus_get_live_consensus() function.

This change has two results:

a) It makes sure we are using a fresh consensus with the right SRV value
   when we are calculating the HSDir hash ring.

b) It ensures that we will not use the sr_get_current/previous()
   functions when we don't have a consensus which would have falsely
   triggered the disaster SRV logic.

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

In Nick's words:

"We want to always return false if the platform is a Tor version, and it
is not as new as 0.3.0.8 -- but if the platform is not a Tor version, or
if the version is as new as 0.3.0.8, then we want to obey the protocol
list.

That way, other implementations of our protocol won't have to claim any
particular Tor version, and future versions of Tor will have the freedom
to drop this protocol in the distant future."

George Kadianakis authored 7 years ago and Nick Mathewson committed 7 years ago

- Fix log message format string.
- Do extra circuit purpose check.
- wipe memory in a clear function
- Make sure we don't double add intro points in our list
- Make sure we don't double close intro circuits.
- s/tt_u64_op/tt_i64_op/